Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing this once and for all #5681

Closed
wants to merge 13 commits into from
Closed

fixing this once and for all #5681

wants to merge 13 commits into from

Conversation

I-am-TURBO
Copy link
Contributor

@I-am-TURBO I-am-TURBO commented Feb 10, 2024 •
edited
Loading

fixing this once and for all

@I-am-TURBO
bv of all Herbi that we're 10k now 1m, Rudolph is a pet now, doopy …
18b9e5c 
…is tradeable ge only
@I-am-TURBO
lin
919d495
@I-am-TURBO
- Removed tradeable: true & tradeable_on_ge: true from Balloon ca…
9ed6b7c 
…t due to it is ment to be untradeable and has the super untradeable code also.

- moved Balloon cat out of discontinued above dyed
- removed `cantBeSacrificed: true`from the guthix, saradomin & zamorak pets.
- removed `cantBeSacrificed: true` from Buggy
- turned Skip from `Coal` to `Herbi` because it is a growable pet.
@I-am-TURBO I-am-TURBO changed the title All Dc & Custom pets BV 1m, -- Rudolph is now pet -- doopy tradeable GE only Changes to CPETS & DCPETS Feb 15, 2024
@gc
Copy link
Collaborator

gc commented Feb 19, 2024

You should try to split up PRs a bit if theyre like this, you have some changes in here that probably shouldnt be mixed together (like making doopy only tradeable on g.e?, and the cantBeSacrificed changes. You'd have to remove those for me to merge this.

@I-am-TURBO
Copy link
Contributor Author

You should try to split up PRs a bit if theyre like this, you have some changes in here that probably shouldnt be mixed together (like making doopy only tradeable on g.e?, and the cantBeSacrificed changes. You'd have to remove those for me to merge this.

okay

@I-am-TURBO
Copy link
Contributor Author

I-am-TURBO commented Feb 19, 2024 •
edited
Loading

You should try to split up PRs a bit if theyre like this, you have some changes in here that probably shouldnt be mixed together (like making doopy only tradeable on g.e?, and the cantBeSacrificed changes. You'd have to remove those for me to merge this.

okay so I did as you said. didn't really know how to split this one up since it is already done, but I edited this one and posted the changes in the description.

@I-am-TURBO
Copy link
Contributor Author

ugh I'm just messing up

@I-am-TURBO I-am-TURBO closed this Feb 19, 2024
@I-am-TURBO I-am-TURBO changed the title Changes to CPETS & DCPETS fixing this once and for all Feb 19, 2024
@I-am-TURBO I-am-TURBO deleted the cpets branch February 19, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@I-am-TURBO @gc